Check that container exists before calling removeChildren
#286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses an error I've repeatedly encountered in production (may have something to do with `React.Suspense` and/or `React.lazy` imports. Just ensures that the container exists before attempting to remove it. ``` TypeError: Cannot read properties of null (reading 'removeChildren') at removeChildren (../../src/ReactPixiFiber.js:122:12) at xb (../../node_modules/react-reconciler/cjs/react-reconciler.production.min.js:131:296) at Jf (../../node_modules/react-reconciler/cjs/react-reconciler.production.min.js:174:304) at ih (../../node_modules/react-reconciler/cjs/react-reconciler.production.min.js:171:235) at vc (../../node_modules/react-reconciler/cjs/react-reconciler.production.min.js:36:324) at Pc (../../node_modules/react-reconciler/cjs/react-reconciler.production.min.js:169:278) at Zg (../../node_modules/react-reconciler/cjs/react-reconciler.production.min.js:160:369) ```
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit aa060d6:
|
michalochman
requested changes
Oct 9, 2022
There was a problem hiding this comment.
Thanks @kyle-villeneuve! Seems like an obvious fix. I will merge and release it if you can update code formatting.
Co-authored-by: Michał Ochman <[email protected]>
|
Ok, I've committed your suggestion, thanks. @michalochman |
michalochman
approved these changes
Oct 11, 2022
|
@kyle-villeneuve thanks! The fix is now included in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an error I've repeatedly encountered in production (may have something to do with
React.Suspenseand/orReact.lazyimports. Just ensures that the container exists before attempting to remove its contents.