Remove namespace from Typescript definition

[smvilar]

I'm not sure if it's a bug or it's just that I don't understand how the namespace works, but currently in order to do

import { CustomPIXIComponent } from 'react-pixi-fiber';

instead Typescript requires me to write

import { CustomPIXIComponentNamespace } from 'react-pixi-fiber';
CustomPIXIComponentNamespace.CustomPIXIComponent

and then the compiled JS code fails because
Uncaught TypeError: Cannot read property 'CustomPIXIComponent' of undefined

I think this namespace should be removed.

[codecov]

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #64   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         204    204           
=====================================
  Hits          204    204

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e1b628...ae28709. Read the comment docs.

[michalochman]

@Fabiantjoeaon care to elaborate?

[Fabiantjoeaon]

Hmm I see. I added this namespace around CustomPIXIComponent because of this issue (that has already been closed):
#54

I think removing it might cause to re-create this bug. Perhaps there is another solution ? @smvilar

[smvilar]

Hi @Fabiantjoeaon, I don't understand how to reproduce the bug you were having. Is it building the lib itself?
I'm not sure why you added that namespace, since from what I understand, if I were using this lib in JS I'd write:

import { CustomPIXIComponent } from 'react-pixi-fiber';

so that's probably what I want to do also in TS. If I'm forced to write

import { CustomPIXIComponentNamespace } from 'react-pixi-fiber';

that just resolves to undefined, since it doesn't exist.

I honestly thought that nobody was using this lib from TS since it just doesn't compile. You can see it even in test/typescript/index.tsx:

[smvilar]

I just updated the branch to include a functional TS test that you can run, just type

yarn --pure-lockfile // to install typescript
yarn test:ts

and it will compile the test.
You can try with or without the 2nd commit in the branch (the actual fix) to see the difference.

[Fabiantjoeaon]

Hi @smvilar

I tried running your tests. All good.

Regarding reproducing my bug, whenever I remove the namespace from the package in my node_modules directly, I still get the following error:

To be fair, I agree with you that this namespace should be removed, because my solution to solve this error was not very clean, and I think it should be solved in a different way. Perhaps it has something to do with my Typescript version?

What version are you running, and is this installed globally? (because I don't have TS installed globally)

I get the error whenever I use my workspace's version (2.8.3), and when I use my VSCode's version (2.9.1),

[Fabiantjoeaon]

Okay I figured it out!

• I found out we apparently added a own typings file which already included a export for CustomPIXIComponent, which explains my duplicate decleration, apparently to fix another bug that has already been fixed.
• Got it working with TS version 2.9.2

I guess you can merge this fix.

[michalochman]

@Fabiantjoeaon thanks for clarification!

@smvilar I'm going to merge your fix, thanks for bringing that problem up :) can you just update @types/react to the same version that's used in peerDependencies?

[smvilar]

@michalochman ready. Please note that I added a script to test Typescript typings, maybe you want to add this to the CI?

[smvilar]

@Fabiantjoeaon so glad we could figure this out!

[michalochman]

@smvilar can you just add the following line to .circleci/config.yml file after current test command?

- run: yarn test:ts

Thanks!

[smvilar]

@michalochman done! Let's see how it works

[smvilar]

They passed 😄

[michalochman]

@smvilar cool! Much appreciated