Using sbt, Scala 2.10/2.11/2.12 with Scala.js #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made it compatible with Scala 2.10-2.12. Added comment about the sporadic test failures on JVM (though with that change it still fails).
Added more scala options and Laika for doc generation. (For docs a few changes were necessary, to be fixed later.) It seems the problems on JVM build are only reproducible locally, not on travis, so removed the comment.
The tut now includes simple examples with simple results. Also README was updated with some examples. Added the scala.collection.immutable.Map/HashMap implementations instead of the PersistentHashMap of Clojure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem as observed by the scalacheck tests in the math parts, but otherwise it is very similar to the original code. Added travis build, coveralls, tut and Scala.js.
Unfortunately Laika 0.6.0 has some problems with the doc, hopefully 0.8.0 will fix them.