Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Might be saver to pass an array to the rollback() method #2

Merged
merged 1 commit into from
Mar 29, 2017

Conversation

Tjab
Copy link

@Tjab Tjab commented Mar 28, 2017

A refactor in the laravel-framework caused the migrations to fail when the path is a string instead of an array. See the pull request on github: laravel/framework#18535

As the laravel-framework uses arrays itself, it might be saver to do the same here.

return [$this->laravel->basePath().'/'.$this->option('path')];
in
laravel\framework\src\Illuminate\Database\Console\Migrations\BaseCommand.php

@michielfb michielfb merged commit 54f7b92 into michielfb:master Mar 29, 2017
@michielfb
Copy link
Owner

Hi @Tjab,
Thanks for your feedback. I've tested and merged your pull request. Should this also be applied to:

\Michielfb\DataMigrations\Console\Commands\MigrateData::getMigrationPath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants