use rmw_enclave_options_xxx APIs instead. #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya Fujita <[email protected]>
fujitatomoya
commented
Mar 2, 2025
|
@pablogs9 can you take a look? |
pablogs9
reviewed
Mar 3, 2025
pablogs9
requested changes
Mar 3, 2025
Signed-off-by: Tomoya Fujita <[email protected]>
|
@pablogs9 ros2/rmw#393 has been merged, is this good to go? |
|
CI is ok, so we are good to go. @fujitatomoya thanks for the contribution! |
|
@pablogs9 you already reverted this PR from rolling? |
|
Hello @fujitatomoya yes, I have reverted it temporarily because it breaks micro-ROS functionality on our hardware in the loop CI/CD, we are still investigating. As soon as I find what happens, I will restore it and open a PR to fix the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #311
related to ros2/rmw#390 and ros2/rmw#390