Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error, notes, and warning based on BiocCheck() #469

Merged
merged 26 commits into from
Apr 3, 2024

Conversation

erawijantari
Copy link
Contributor

No description provided.

R/splitOn.R Outdated Show resolved Hide resolved
@antagomir
Copy link
Member

fine i guess

@antagomir
Copy link
Member

Is this ready?

@antagomir
Copy link
Member

Is this ready?

@erawijantari - can you resolve the conflicts, and pull this through so that we can close the PR?

@antagomir
Copy link
Member

@erawijantari

@antagomir
Copy link
Member

@erawijantari - can you resolve the conflicts, and pull this through so that we can close the PR?

@erawijantari erawijantari deleted the master branch April 3, 2024 07:08
@erawijantari erawijantari restored the master branch April 3, 2024 07:18
@erawijantari
Copy link
Contributor Author

Sorry, seems like I accidentally closed the PR when I synced the forked directory and changed the master branch to devel as was suggested.
But I had checked all change and did not see any conflict.

@antagomir antagomir reopened this Apr 3, 2024
@antagomir antagomir merged commit 889d7fb into microbiome:devel Apr 3, 2024
1 check passed
@antagomir
Copy link
Member

Seems good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants