Delete Dockerfiles specific to old Node versions (v16 and v18)
#302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm ready for this to be merged in. |
|
Merging before end of sprint. Has no impact on the production NMDC EDGE application. |
eecavanna
deleted the
301-delete-obsolete-dockerfiles-ie-the-ones-for-node-v16-and-node-v18
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this branch, I deleted the two
Dockerfiles that were specific to Node v16 and Node v18. I also updated a.dockerignorefile, a GHA workflow definition, "docker compose" files, and documentation accordingly. Finally, I renamed theDockerfilespecific to Node v20 so that its name isDockerfile(without any qualifiers, since there are no alternatives in the repo anymore).