Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. updates to gold_translator.py #384

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Conversation

sujaypatil96
Copy link
Collaborator

As a result of the discussion on microbiomedata/issues#527 a couple of trivial edits needed to be made to the GOLD-to-Mongo ingest pipeline:

  • Use lowercase gold while making CURIEs for GOLD entities
  • Modification to the logic in _get_quantity_value() to accommodate special handling of depth data

NMDC depth.has_minimum_numeric_value — GOLD depthInMeters
NMDC depth.has_maximum_numeric_value — GOLD depthInMeters2

depthInMeters2 may or may not be present in GOLD, so in the cases where it’s not provided:
NMDC depth.has_numeric_value — GOLD depthInMeters

@sujaypatil96 sujaypatil96 merged commit 619a3c5 into main Dec 1, 2023
@sujaypatil96 sujaypatil96 deleted the update-gold-translator branch December 1, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants