Mix in orcid jwt flow with client_credentials flow #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge updates into playground
dwinston
requested review from
PeopleMakeCulture,
shreddd,
naglepuff and
eecavanna
eecavanna
reviewed
Nov 27, 2023
eecavanna
reviewed
Nov 27, 2023
eecavanna
reviewed
Nov 27, 2023
| ORCID_CLIENT_ID = os.getenv("ORCID_CLIENT_ID") | ||
|
|
||
| # https://orcid.org/.well-known/openid-configuration | ||
| # XXX do we want to live-load this? |
There was a problem hiding this comment.
If the JSON content at https://orcid.org/oauth/jwks is something that changes over time (I don't know whether it is), I'd prefer to live-load it.
There was a problem hiding this comment.
hmm. yeah, will include in refactoring.
eecavanna
reviewed
Nov 27, 2023
eecavanna
previously approved these changes
Nov 27, 2023
|
@eecavanna great feedback, thanks. |
* Consolidate workflows for building docker images and deploying to Spin into one workflow * Remove docker-build.sh in favor of letting GitHub Actions handle Docker build and push * Update Release Process doc with info about initiating via GitHub Releases * Replace Rancher-Action with generic HTTP call * Replace release event with tag push event, which is required for semver metadata * Remove unnecessary pr event * Add more release instructions
* fix: Handle `anyOf` in JSON Schema property * Indicate function return value type * Refactor function and add comments * fix: Prefix class name with `nmdc:` * Implement helper function to process both single-ref and multi-ref specs * Document prefix functionality * Fix punctuation in comment * Update dictionary and function to accommodate multiple classes per collection * WIP: Update doc link maker to accommodate collections that map to multiple classes * Clarify variable names * Add comments in an attempt to clarify code * Delete commented-out code that doesn't accommodate multi-class collections * Add tests covering some corner cases * Fix inaccurate type hint * Clarify docstring * Replace reference to nonexistent dict and implement preliminary patch * Make the collection name bold on the search page * Update search page to account for collections mapping to multiple classes * Remove redundant type hints * style: black format * panic on no-type given * add script and api function * update script * Refactor runtime client methods to raise for status and parse and return results * handle omics processing records * update docstring * update to include correct prefix * update to use use new insdc_bioproject_identifiers slot on omics_processing * style: black format * add typecodes enpoint (#386) unauthenticated. closes #385 * update .gitpod.yml * add sshproxy.sh for nersc tunneling * update make cmd * add gitpod affordance * add gitpod dockerfile * update gitpod stuff * rename * update Makefile * fix * gitpod: pull dev mdb * fix * fix make target * Separate dev and production deployments in GitHub workflow (#382) * Consolidate workflows for building docker images and deploying to Spin into one workflow * Remove docker-build.sh in favor of letting GitHub Actions handle Docker build and push * Update Release Process doc with info about initiating via GitHub Releases * Replace Rancher-Action with generic HTTP call * Replace release event with tag push event, which is required for semver metadata * Remove unnecessary pr event * Add more release instructions * style: fix, and elaborate a bit * Revert stuff This reverts commit 1b2372d. * style: fix, and elaborate a bit --------- Co-authored-by: eecavanna <[email protected]> Co-authored-by: Donny Winston <[email protected]> Co-authored-by: Michael Thornton <[email protected]> Co-authored-by: Donny Winston <[email protected]> Co-authored-by: Jing Cao <[email protected]> Co-authored-by: Patrick Kalita <[email protected]>
Co-authored-by: Donny Winston <[email protected]>
…o SubmissionPortalTranslator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can load
/orcid_authorizeto obtain orcid JWT. Then authorize usingclient_credentialsflow using orcid jwt asclient_idand emptyclient_secret. Will create user with orcid as username if it doesn't exist. Returns a user token just like the username/password flow.closes #333