Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow mongodb update command via POST /query:run #411

Merged
merged 7 commits into from
Dec 6, 2023
Merged

allow mongodb update command via POST /query:run #411

merged 7 commits into from
Dec 6, 2023

Conversation

dwinston
Copy link
Collaborator

@dwinston dwinston commented Dec 4, 2023 •
edited by PeopleMakeCulture
Loading

closes #356

A successful update query run

  • sends a 200
    image
  • updates the document
    image

A poorly formatted update query run

  • Throws an error if no records found
    image

  • Throws an error if query is poorly formatted
    image

@dwinston
allow mongodb update command via POST /query:run
c0aa18e 
closes #356
@dwinston
fix: various
fbf8704 
also got to use HTTP code 418. so a good day.

closes #356
@dwinston dwinston marked this pull request as ready for review December 4, 2023 22:24
@eecavanna eecavanna self-requested a review December 5, 2023 23:00
eecavanna
eecavanna previously approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@eecavanna eecavanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two comments about strings. I don't consider either one to be a deal breaker (i.e. merge blocker).

PeopleMakeCulture
PeopleMakeCulture approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@PeopleMakeCulture PeopleMakeCulture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@PeopleMakeCulture PeopleMakeCulture merged commit 166213e into main Dec 6, 2023
@PeopleMakeCulture PeopleMakeCulture deleted the 356-allow-updates-via-query-run branch December 6, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeopleMakeCulture PeopleMakeCulture PeopleMakeCulture approved these changes

@eecavanna eecavanna eecavanna left review comments

@aclum aclum Awaiting requested review from aclum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

revisit endpoints used to update mongo data
3 participants
@dwinston @PeopleMakeCulture @eecavanna