Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

berkeley: Restore tests that were being skipped by mistake (oops) #688

Merged

Conversation

eecavanna
Copy link
Collaborator

Description

In PR #676, I configured pytest to skip running the following tests:

  1. All tests in: tests/test_data/test_neon_benthic_data_translator.py
  2. All tests in: tests/test_data/test_neon_soil_data_translator.py
  3. All (4) tests in: tests/test_ops/test_gold_api_ops.py

In this PR, I have undone that; i.e. I've unskipped them, so that pytest will run them.

Fixes #687

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • 👀

Configuration Details: none

  • My code follows the style guidelines of this project (have you run black nmdc_runtime/?)
  • I have performed a self-review of my code

@eecavanna eecavanna self-assigned this Sep 19, 2024
@eecavanna eecavanna changed the title Restore tests that were being skipped by mistake (oops) berkeley: Restore tests that were being skipped by mistake (oops) Sep 19, 2024
@eecavanna
Copy link
Collaborator Author

The 6 tests that I expect to fail in this branch do, indeed, fail.

image

@eecavanna
Copy link
Collaborator Author

Merging without review. This change was discussed during a meeting today and in the comments at: #676 (comment)

@eecavanna eecavanna merged commit da278d5 into berkeley Sep 19, 2024
1 of 2 checks passed
@eecavanna eecavanna deleted the 687-berkeley-tests-in-3-files-are-being-skipped-by-mistake branch September 19, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant