-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mapping for multiple environments #741
Conversation
f2c0593
to
f400616
Compare
f400616
to
43bf7cc
Compare
@marySalvi status update? |
@mslarae13 We are meeting tomorrow to debug and get a working solution. I will post an updated ETA as soon as possible. |
ab46b17
to
16115ca
Compare
PLANT_ASSOCIATED = "plant-associated" | ||
SEDIMENT = "sediment" | ||
SOIL = "soil" | ||
WATER = "water" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue here related to microbiomedata/submission-schema#186
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a lot of this is on the right track, but it seems to be missing a few pieces related to how the JGI and EMSL tabs are handled in conjunction with the multiple environments. If you want to go over this in more detail together just let me know.
d1409cc
to
38a14c5
Compare
@marySalvi Sorry I sort of led you astray a bit with my initial feedback. After looking at this again the real key is not adding the analysis templates (the EMSL and JGI ones) into the enum, but rather to skip setting the As to not have a bunch more back and forth on this I went ahead and expanded the test data to capture this use case and updated the translator logic. |
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Replace
# (issue)
below with a reference to the issue that this PR addresses, of the form#\d+
. If merging this PR should close the issue, useFixes
orCloses
. Then delete this paragraph.Fixes # 1367
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration, if it is not simply
make up-test && make test-run
.Configuration Details: none
Definition of Done (DoD) Checklist:
A simple checklist of necessary activities that add verifiable/demonstrable value to the product by asserting the quality of a feature, not the functionality of that feature; the latter should be stated as acceptance criteria in the issue this PR closes. Not all activities in the PR template will be applicable to each feature since the definition of done is intended to be a comprehensive checklist. Consciously decide the applicability of value-added activities on a feature-by-feature basis.
black nmdc_runtime/
?)docs/
and in https://github.com/microbiomedata/NMDC_documentation/?)make up-test && make test-run
)