Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify explanation of access_token property in Python notebook (in docs/nb) #872

Merged

Conversation

eecavanna
Copy link
Collaborator

On this branch, I consolidate two explanatory paragraphs in a Python notebook in an attempt to communicate an idea more clearly to readers.

Details

N/A

Related issue(s)

Related to (already closed issue): #868

Related subsystem(s)

  • Runtime API (except the Minter)
  • Minter
  • Dagster
  • Project documentation (in the docs directory)
  • Translators (metadata ingest pipelines)
  • MongoDB migrations
  • Other

Testing

  • I tested these changes (explain below)
  • I did not test these changes

I tested these changes by reading them back to myself.

Documentation

  • I have not checked for relevant documentation yet (e.g. in the docs directory)
  • I have updated all relevant documentation so it will remain accurate
  • Other (explain below)

Maintainability

  • Every Python function I defined includes a docstring (test functions are exempt from this)
  • Every Python function parameter I introduced includes a type hint (e.g. study_id: str)
  • All "to do" or "fix me" Python comments I added begin with either # TODO or # FIXME
  • I used black to format all the Python files I created/modified
  • The PR title is in the imperative mood (e.g. "Do X") and not the declarative mood (e.g. "Does X" or "Did X")

@eecavanna eecavanna self-assigned this Jan 20, 2025
@eecavanna
Copy link
Collaborator Author

Merging without review ahead of tomorrow's documentation reveal.

@eecavanna eecavanna merged commit a557d5b into main Jan 20, 2025
@eecavanna eecavanna deleted the 868b-clarify-access-token-explanation-in-docs-notebook branch January 20, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant