-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the use of alldocs
with respective collections for record retrieval in NCBI exporter
#907
Conversation
alldocs
with respective collections for record retrieval in NCBI exporter
I'll review this PR this morning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these changes to accommodate the new sparseness of the "all docs" (maybe one day renamed to "all refs" or something) collection, @sujaypatil96.
I made some comments related to type hints, docstrings, and 1-2 variable names.
Thank you for the review comments @eecavanna, they were very helpful! I was being lazy by not adding type hints and docstrings. I've done that now. I think I've addressed all your review comments, feel free to drop another review. |
Thanks for making those changes, @sujaypatil96! I found the docstrings and type hints helpful in keeping track of what is happening in the code (while reading it). I left one follow-up comment about a type hint that I thought was more broad than necessary. I'll defer to you about that. You can merge already or edit-and-merge. |
Co-authored-by: eecavanna <[email protected]>
Fixes microbiomedata/issues#1063
TODO:
On this branch, I...
Details
...
Related issue(s)
...
Related subsystem(s)
docs
directory)Testing
I tested these changes by...
Documentation
docs
directory)Maintainability
study_id: str
)# TODO
or# FIXME
black
to format all the Python files I created/modified