-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor migrator classes into own modules and fix YAML file loading #1340
Refactor migrator classes into own modules and fix YAML file loading #1340
Conversation
…_schema` package
In case this PR is still open on Tuesday, I can present the changes during the migration squad meeting that day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eecavanna this looks great to me! A lot easier to digest and understand than one big file. I'll let @turbomam approve this since he knows the structure of the repo much better than me. Is there a way we can include dumping the output of a migration(s) into a yaml file as we did with the migration_recursion.py
file so that we can test the migrations while writing them?
Thanks, @brynnz22! The On a side note about testing, after this branch has been merged in, I'm planning to add some |
Action items from pair review
|
I updated the
|
Summary
migrators
that contains the migration-specific classesMigratorBase
class frommigration_recursion.py
into its own module within themigrators
packagemigration_recursion.py
into its own module within themigrators
packageassets/
directory within themigrators
packagemigration_recursion.py
into a newCurieMigrator
classforce_prefix
property from theMigratorBase
class (it still exists on theCurieMigrator
class)import
things residing innmdc_schema/migrators/
(instead of only things residing at the top level ofnmdc_schema/
).pip install /path/to/local/clone/of/nmdc-schema
and confirming the followingimport
statement worked:nmdc-schema
development environmentFileNotFoundError
regarding data YAML file #1310