-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return 404 not found response for unknown studies and samples #1058
Comments
The API call to retrieve the object does return a 404 in these cases (you can see that in the inspector), but we should indeed show some indication that the study/sample is not found, it currently just silently fails to initialize the view. Instead of 404-ing the entire page, I believe the right thing is to display something like "Sample not found." in the main app content area. |
I'd like for us to do both, as these behaviors are not mutually exclusive. The status code and response body are separate concerns for an HTTP response. I agree with returning a human-readable HTML response ("sample not found"), but I would like In the meantime, I will use |
The first URL listed ( The second URL is the preferred method of getting information out of the Data Portal's postgres database, and corresponds to an endpoint in our FastAPI backend. That one will throw the |
examples:
related to implementation of microbiomedata/issues#423
The text was updated successfully, but these errors were encountered: