Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement API endpoint that returns nmdc-server application version #1108

Closed
eecavanna opened this issue Jan 10, 2024 · 1 comment · Fixed by #1111
Closed

Implement API endpoint that returns nmdc-server application version #1108

eecavanna opened this issue Jan 10, 2024 · 1 comment · Fixed by #1111
Assignees
@eecavanna
Labels
priority: medium type: feature New feature or request X SMALL Less than 1 day

Comments

@eecavanna
Copy link
Collaborator

eecavanna commented Jan 10, 2024 •
edited
Loading

I want HTTP clients to be able to determine the application version number without loading up its Swagger UI.

Notes:

  • The application version is accessible (to Python code within the nmdc-server repository) in nmdc-server/nmdc_server/__init__.py

Related: microbiomedata/nmdc-runtime#372 & https://github.com/microbiomedata/nmdc-runtime/blob/8e06922d55db261c28a855ea5624011370804fe0/nmdc_runtime/api/main.py#L339-L345
@eecavanna eecavanna added type: feature New feature or request priority: medium X SMALL Less than 1 day labels Jan 10, 2024
@eecavanna eecavanna self-assigned this Jan 10, 2024
@eecavanna eecavanna linked a pull request Jan 10, 2024 that will close this issue
Implement /api/version API endpoint that returns app version #1111
Merged
@ssarrafan
Copy link

This looks like a new GH issue from last week. I'll move it to the new sprint, but please remove if not actively working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eecavanna eecavanna

Labels
priority: medium type: feature New feature or request X SMALL Less than 1 day
Projects
No open projects
2024 - Sprint 28 - January 15-January 26, 2024
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement /api/version API endpoint that returns app version microbiomedata/nmdc-server
2 participants
@ssarrafan @eecavanna