-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement /api/version
API endpoint that returns app version
#1111
Implement /api/version
API endpoint that returns app version
#1111
Conversation
Linting is failing in GitHub Actions. I don't know how I can run the same checks locally so as to avoid racking up GHA costs. tox: lint
lint: commands[0]> flake8 nmdc_server tests
nmdc_server/api.py:11: [I001] isort found an import in the wrong position
nmdc_server/api.py:12: [I005] isort found an unexpected missing import
nmdc_server/api.py:26: [I001] isort found an import in the wrong position
lint: exit 1 (1.47 seconds) /home/runner/work/nmdc-server/nmdc-server> flake8 nmdc_server tests pid=3093
lint: FAIL ✖ in 3.99 seconds For now, I'll look at the flake8 docs and try to map those to the code. |
You should be able to run locally with If you just want to run the linting test, try You can also try auto-formatting the files with |
Thanks, @naglepuff. By the way, I made another commit before I saw your message (it's being GHA tested now). I had been trying to run everything (including |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks! I forgot to say: you can "squash" the branch into a single commit (upon merge, assuming GitHub still offers that ability) if you want. I consider most of the commits to have been "noise." |
Appears to be active. Moving to new sprint. Please remove from sprint if not actively working on this. |
Summary
/api/version
) that returns the application version numberScreenshot showing that the API returns the same version number as Swagger UI shows: