Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use tagged version of nmdc-ontology #1183

Closed
aclum opened this issue Mar 14, 2024 · 11 comments · Fixed by #1209
Closed

use tagged version of nmdc-ontology #1183

aclum opened this issue Mar 14, 2024 · 11 comments · Fixed by #1209
Assignees

Comments

@aclum
Copy link
Contributor

aclum commented Mar 14, 2024

Placeholder for updating to a tagged release version of nmdc-ontology. Changes in main in nmdc-ontology recently broke data portal ingest (b/c of Cyclic graph) so this is a good time to update it.

Realvant code

envo_url = "https://raw.githubusercontent.com/microbiomedata/nmdc-ontology/main/nmdco-classes.json"

@aclum
Copy link
Contributor Author

aclum commented Mar 14, 2024

cc @turbomam let us know when you have a tagged nmdc-ontology release that resolves the cyclical graph issue.

@ssarrafan
Copy link

@aclum should this be in the current sprint? Who owns this issue?

@ssarrafan
Copy link

@mbthornton-lbl @naglepuff is this something you are currently working on?

@aclum
Copy link
Contributor Author

aclum commented Apr 3, 2024 via email

@aclum
Copy link
Contributor Author

aclum commented Apr 3, 2024 via email

@ssarrafan
Copy link

@naglepuff @marySalvi I'm assigning this to you in case one of you has time to do this week.

@ssarrafan
Copy link

@marySalvi said she is looking into this one. I'll remove Mike from this ticket.

@marySalvi
Copy link
Collaborator

@turbomam @aclum Do we want to always use the latest release or do we want to 'pin' to a specific release? Pinning would require manual updating but potentially less friction for testing different releases

@turbomam
Copy link
Member

turbomam commented Apr 5, 2024

I defer to @aclum

I am doing active development in the main branch. I'm pretty careful about what I merge, but I haven't been doing an ingest each time. So a pinned release would be safer.

@aclum
Copy link
Contributor Author

aclum commented Apr 8, 2024

The request is for a pinned release. We haven't been doing this and it broke ingest a few weeks ago. The nmdc-server code and therefore ingest will be more stable. I'd like updating the pinned version to be part of the monthly release cycle. That is, if Mark has a new version there would be a nmdc-server ticket to update the nmdc-ontology version, ideally at least a week before the monthly production release so we could test ingest and the data portal interface on dev. cc @shreddd @pkalita-lbl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants