Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ingest of functional_annotation_agg for compatibility with new slot #1431

Closed
aclum opened this issue Oct 28, 2024 · 5 comments · Fixed by #1433
Closed

Update ingest of functional_annotation_agg for compatibility with new slot #1431

aclum opened this issue Oct 28, 2024 · 5 comments · Fixed by #1433
Assignees

Comments

@aclum
Copy link
Contributor

aclum commented Oct 28, 2024

Katherine has some PRs which change slot names on functional_annotation_agg microbiomedata/nmdc-schema#2203.

This ticket is for the updates needed to nmdc_server

cc @kheal

Please confirm this can be done by Nov 11.

@aclum
Copy link
Contributor Author

aclum commented Oct 28, 2024

@naglepuff assigning to you since you've handled the other changes to the functional annotation aggregation work.

@kheal
Copy link

kheal commented Oct 28, 2024

We have not yet translated the MetaP results into the functional_annotation_agg collection (dependent on a 1 more schema change + aggregation change). However, we have a PR open to change the structure of the functional_annotation_agg records (switched a field name) for the Sequencing results, so I think we do still need a change in the server ingest to accomodate for that.

@aclum
Copy link
Contributor Author

aclum commented Oct 28, 2024

thanks for the clarification, i've updated the title and description.

@kheal kheal changed the title Remove ingest of metap_gene_function_aggregation Update ingest of functional_annotation_agg for compatibility with new slot Oct 29, 2024
@kheal
Copy link

kheal commented Nov 8, 2024

The schema dependencies have been merged in for this. Note that this collection functional_annotation_agg still only contains MetaT and MetaG data (not yet MetaP, which are still housed in the metap_gene_function_aggregation).

@aclum aclum linked a pull request Nov 15, 2024 that will close this issue
@aclum
Copy link
Contributor Author

aclum commented Nov 15, 2024

This was merged into dev yesterday and @naglepuff did an ingest. Everything is working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants