Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct slot when querying gene aggregations #1433

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

naglepuff
Copy link
Collaborator

Breaking Changes

This PR includes changes to ingest. Until upstream data is migrated to include the schema changes that necessitated this change, ingest will fail to create records based on functional_annotation_aggs

Summary of changes

The slot that links functional_annotation_agg members to their workflow_executions has been changed to be was_generated_by. This change is now reflected in ingest code.

To test

Make sure ingest populates the ____GeneFunctionAggregation tables.

@naglepuff naglepuff force-pushed the 1431-update-annotation-ingest branch from be13b70 to 9aa5e09 Compare November 14, 2024 18:58
@naglepuff naglepuff marked this pull request as ready for review November 14, 2024 20:33
@naglepuff
Copy link
Collaborator Author

@marySalvi this is ready for review, now that dev mongo has been migrated

@naglepuff naglepuff merged commit 887530c into main Nov 14, 2024
2 checks passed
@naglepuff naglepuff deleted the 1431-update-annotation-ingest branch November 14, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ingest of functional_annotation_agg for compatibility with new slot
2 participants