Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfigure deploy workflow to use main/latest/version number Docker tags #1106

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

pkalita-lbl
Copy link
Collaborator

Fixes microbiomedata/issues#554

These changes update the deploy.yml workflow file to:

  • Tag Docker image with main for pushes to the main branch. Tag Docker image with prod and X.Y.Z for pushes to tags like vX.Y.Z. This is accomplished by using the docker/metadata-action action.
  • Redeploy the Rancher nmdc-dev workloads on pushes to main and nmdc workloads on pushes to version tags. Previously only nmdc-dev workloads were redeployed on pushes to main.

Once these changes are in place I'll update Rancher to point the nmdc workloads to the new prod tagged images. Then when a GitHub Release is created with a new version tag the deployment will happen automatically with no need to update anything in Rancher. This also brings this repository inline with what nmdc-runtime does.

@eecavanna eecavanna self-requested a review January 6, 2024 00:59
Copy link
Collaborator

@naglepuff naglepuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have one comment about the changes, which is more for educational purposes than anything else.

@pkalita-lbl pkalita-lbl merged commit 5dbab5a into main Jan 9, 2024
2 checks passed
@pkalita-lbl pkalita-lbl deleted the issue-554-docker-tags branch January 9, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use main and prod tags for Docker images in nmdc-server
3 participants