Used namespacedSecrets endpoint to get/update rancher secrets in ingest #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naglepuff
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
LGTM, but I do have one question:
What are the odds we switch away from using namespaced secrets in the future? Coming back here to edit that seems like it could be tedious. Do you think its worth using an environment variable to handle the "secrets" vs. "namespacedSecrets" segment of the URL?
|
Fair question. I don't think that's likely, but that's just based on vibes not any Rancher expertise. Maybe if it needs to be updated in the future we could switch to passing in full endpoints (e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick revision to #1103. I had been testing that locally against the "development" project (which we don't really use anymore). This updates the ingest CLI to use the correct endpoint for the "production" project where we used namespaced secrets.