Specify join for envo term when faceting omics_processing #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When faceting omics_processing records on one of the envo terms, be sure to correctly join with envo terms, instead of using a cartesian product.
jeffbaumes
requested changes
Jan 19, 2024
There was a problem hiding this comment.
This fix makes a lot of sense to me and your analysis on the parent issue confirms it's working as expected. One thing unclear to me is whether this worked before #991 or if the omics bar chart never worked properly when querying by envo terms, but it is probably not necessary for find out.
I have one consistency-based suggested change.
naglepuff
force-pushed
the
1115-envo-omics-filters
branch
from
db5f617 to
15ebb01
Compare
jeffbaumes
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1115
This PR changes how subclasses of
BiosampleFilterjoin to theomics_procesingtable.Previously, they didn't specify at all, so when a filter on an envo term was applied to a search on
omics_processingrecords, there was a Cartesian product and no filtering was done.Now, those subclasses that represent
<EnvoTerm>Filters use thejoin_envofunction of theBaseFilterclass to perform the join and correctly filter omics processing results.