Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to submission-schema 10.0.0 #1119

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Upgrade to submission-schema 10.0.0 #1119

merged 2 commits into from
Jan 25, 2024

Conversation

pkalita-lbl
Copy link
Collaborator

No description provided.

@eecavanna
Copy link
Collaborator

The changes look straightforward to me (in isolation, not knowing their implications):

  • Updating a dependency to a new version, which impacts its integrity "check value"
  • Importing an object from a package instead of a first-party file
  • Deleting the first-party file from which that object used to be imported

naglepuff
naglepuff approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@naglepuff naglepuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Love to see a good +4, -20k

@pkalita-lbl pkalita-lbl merged commit 21773ed into main Jan 25, 2024
2 checks passed
@pkalita-lbl pkalita-lbl deleted the submission-schema-10.0.0 branch January 25, 2024 20:33
@pkalita-lbl pkalita-lbl mentioned this pull request Jan 26, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naglepuff naglepuff naglepuff approved these changes

@marySalvi marySalvi Awaiting requested review from marySalvi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkalita-lbl @eecavanna @naglepuff