Allow different post-ORCID login behaviors #1130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a
behavior
query parameter to the existing/login
and/token
endpoints in order to change the behavior of what happens to the token after authenticating with ORCID. The default,web
, retains the current behavior: store the token in a session cookie and redirect to the home page. The new ones are:jwt
which just returns a plain string response of the tokenapp
which redirects to the app's token collection page (the hostname is configurable with a new variable here) with the token in a query parameterAt Shreyas's suggestion I did look to see if we could avoid re-encoding the token after the
authorize_access_token
function automatically decodes it, but nothing really jumped out to me. As far as I can tell the re-encoding isn't hurting anything so I'm inclined to just let it be.