Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make certain JGI columns always read-only in DataHarmonizer #1136

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

pkalita-lbl
Copy link
Collaborator

Re: microbiomedata/issues#412 (will close once it has been tested on dev)

These changes make a set of JGI-related columns read-only in DataHarmonizer. This does not prevent the columns from being populated by importing an XLSX file. This is a feature, not a bug.

To test:

  • Go to any submission with a JGI MG and/or JGI MT tab
  • Enter data in the first tab to ensure that some rows will display in the JGI tab(s)
  • On the JGI tab(s) ensure that the indicated columns cannot be edited

Copy link
Collaborator

@naglepuff naglepuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkalita-lbl pkalita-lbl merged commit e301cf2 into main Feb 13, 2024
2 checks passed
@pkalita-lbl pkalita-lbl deleted the issue-412-readonly-jgi-columns branch February 13, 2024 23:51
@mslarae13
Copy link
Contributor

@pkalita-lbl Looks great!!
I think when we have the API, we will have to look into not including these columns in the sheet download. Cuz if I edit it in excel, and then import it does change the values. But I think that's a different issue. I think that is part of the API development.

I like that the cursor turns into a 🚫 when hovering over those columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants