Fix broken GET submission endpoint #1151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial Fix #1150
Fix #1148
Using
**
to passkwargs
proved to be unreliable, resulting in an inability to open submissions on the submission portal.To reproduce the issue locally I restored the most recent backup from NERSC CFS and ran
Logged in as an admin user, I was unable to open any submissions until applying the changes.
While testing, I noticed a bug that would wipe out submission roles on migration. In order to stop this,
SubmissionRole
is now carried over in the same way thatUserLogin
s andSubmissionMetadata
s are. In order to fully fix that issue, I would propose re-running the migration. Or performing the query:in dev, since recent migrations have already wiped out that table.