Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Study page fixes #1164

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Study page fixes #1164

merged 3 commits into from
Mar 6, 2024

Conversation

marySalvi
Copy link
Collaborator

  • Limits Team section to three lines and overflow scrolls
  • Does not show PI and ORCID on consortia
  • Study_count on Parent studies is a sum of its count and its childrens' counts
  • Fixes bug where consortia children were not disabled when the parent was selected.

@marySalvi
Update Bio component
1a3eea5 
Remove PI's from Consortia. Limit team to 3 lines and scroll overflow
@marySalvi
Make children disabled when parent selected on consortia
cdea009
@marySalvi
Update study data
3d04854 
Display a sum total of study counts on parent studies. Fix parent study stacking.
@marySalvi marySalvi requested a review from naglepuff February 29, 2024 23:21
naglepuff
naglepuff approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@naglepuff naglepuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If you can figure out the 3 dots thing feel free to fix here, otherwise I say merge it

@marySalvi marySalvi merged commit 2be0f75 into main Mar 6, 2024
2 checks passed
@marySalvi marySalvi deleted the study-page-fixes branch March 6, 2024 20:01
@marySalvi marySalvi mentioned this pull request Mar 22, 2024
Closed
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naglepuff naglepuff naglepuff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marySalvi @naglepuff