-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement landing page for submission portal #1170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. I'll let people with more Vue experience weigh in on the finer points.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes but overall looks great!
I have addressed all the review feedback.
|
I'm ready for this to be merged in (assuming nobody objects to its contents). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to swoop in last minute like this but the "i" in ORCID should be capitalized. The "i" in ORCID iD is lowercase.
Co-authored-by: Michael Nagler <[email protected]>
Dismissing review because, even though I made the requested changes, I think GitHub is preventing me from merging until the requester approves them. In this case, I think the changes are self-explanatory, and I want to merge this in and close the issue before the sprint ends.
In this branch, I added some new sections to the submission portal landing page.
TitleBanner.vue
This component contains a page title and subtitle overlaying a banner image. The component was modeled after a header on the NMDC website.
IconBar.vue
This component contains a row of three icon-title pairs, each pair linking to some documentation. The icons belong to the Material Design Icons library, which is used elsewhere in the code base.
IntroBlurb.vue
This component contains three paragraphs that introduce the submission portal. In this component's name, I used "blurb" to refer to the entire set of text.
This is only visible when the user is either (a) logged out; or (b) logged in, but does not have any submissions.
LoginPrompt.vue
This component contains a plainly-styled "alert" inviting the visitor to log into ORCiD; or create an ORCiD if they don't have one. This takes the place of the previous, loose login message.
Components in context
Here are links to screenshots showing the components in context.
There is one remaining task, but I don't want to hold up the review(s) for it. That remaining task is to finalize the link to the schema documentation. I will pursue that after requesting reviews as I don't expect it to have an impact on the reviews (it'll be a one-line change).