Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement landing page for submission portal #1170

Merged
merged 14 commits into from
Mar 7, 2024

Conversation

eecavanna
Copy link
Collaborator

@eecavanna eecavanna commented Mar 3, 2024

In this branch, I added some new sections to the submission portal landing page.

TitleBanner.vue

This component contains a page title and subtitle overlaying a banner image. The component was modeled after a header on the NMDC website.

image

Note: The banner image is a 470 KB PNG file (i.e. submission-portal-hero.png). I failed to find an SVG version and don't think one exists. Given that the image contains a color gradient, I'm wondering whether a JPG version would be significantly smaller while being insignificantly lower quality.

IconBar.vue

image

This component contains a row of three icon-title pairs, each pair linking to some documentation. The icons belong to the Material Design Icons library, which is used elsewhere in the code base.

IntroBlurb.vue

image

This component contains three paragraphs that introduce the submission portal. In this component's name, I used "blurb" to refer to the entire set of text.

This is only visible when the user is either (a) logged out; or (b) logged in, but does not have any submissions.

LoginPrompt.vue

image

This component contains a plainly-styled "alert" inviting the visitor to log into ORCiD; or create an ORCiD if they don't have one. This takes the place of the previous, loose login message.

Components in context

Here are links to screenshots showing the components in context.

  • Visitors that are not logged in will see this.
  • Visitors that are logged in and have no submissions will see this.
  • Visitors that are logged in and have submissions will see this.

There is one remaining task, but I don't want to hold up the review(s) for it. That remaining task is to finalize the link to the schema documentation. I will pursue that after requesting reviews as I don't expect it to have an impact on the reviews (it'll be a one-line change).

@eecavanna eecavanna self-assigned this Mar 3, 2024
@eecavanna eecavanna linked an issue Mar 3, 2024 that may be closed by this pull request
@eecavanna eecavanna added type: feature New feature or request SMALL 1-3 days javascript Pull requests that update Javascript code GSP2023 Add to any issue related to GSP 2023 goals submission-portal labels Mar 3, 2024
@eecavanna eecavanna marked this pull request as ready for review March 3, 2024 19:21
Copy link
Collaborator

@pkalita-lbl pkalita-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. I'll let people with more Vue experience weigh in on the finer points.

Copy link
Collaborator

@marySalvi marySalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes but overall looks great!

@eecavanna
Copy link
Collaborator Author

eecavanna commented Mar 6, 2024

I have addressed all the review feedback.

FYI: I am still waiting on guidance from a team member regarding where one of the links will point. I'll reach out to her again about it.

@eecavanna
Copy link
Collaborator Author

I'm ready for this to be merged in (assuming nobody objects to its contents).

Copy link
Collaborator

@naglepuff naglepuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to swoop in last minute like this but the "i" in ORCID should be capitalized. The "i" in ORCID iD is lowercase.

@eecavanna eecavanna requested a review from naglepuff March 7, 2024 23:07
@eecavanna eecavanna dismissed naglepuff’s stale review March 7, 2024 23:11

Dismissing review because, even though I made the requested changes, I think GitHub is preventing me from merging until the requester approves them. In this case, I think the changes are self-explanatory, and I want to merge this in and close the issue before the sprint ends.

@eecavanna eecavanna merged commit dfd29b2 into main Mar 7, 2024
2 checks passed
@eecavanna eecavanna deleted the 1144-create-submission-portal-landing-page branch March 7, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSP2023 Add to any issue related to GSP 2023 goals javascript Pull requests that update Javascript code SMALL 1-3 days submission-portal type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create submission portal landing page
4 participants