Update links in header menu to match website menu #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkalita-lbl
approved these changes
Mar 12, 2024
pkalita-lbl
deleted the
1152-update-navigation-menu-to-match-latest-nmdc-website
branch
|
Thanks for reviewing and merging this while I was out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR branch, I updated the header menu of the Data Portal to match the header menu of the website.
Here's a screenshot showing how the two sites' menus compare at the highest level.
Here's a pair of screenshots showing how they compare at the next level down (only one example dropdown menu is shown here).
Tip for reviewer: Here's a JavaScript snippet you can copy/paste into a web browser's JS console while viewing the website, in order to get a JSON representation of the website's menu. You can
diffthat JSON representation with theweb/src/menus.tsfile in this PR to confirm that the link labels andhrefvalues "line up."