-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metagenomics long read option and logic to UI #1191
Add metagenomics long read option and logic to UI #1191
Conversation
Moving this back into draft. Discussed with @naglepuff and @mslarae13 and decided to not try and sneak this in before the 2023.3 release feature freeze. So we'll just let this PR chill until after that release has been made. |
I think there may be some issues with validation caused by the DH upgrade. This is just a note to my future self to investigate that before marking this ready-to-review again. |
@naglepuff Now that Release 2024.3 is out and I've tested this branch a little more locally, I think this is ready for review and merge. |
@ssarrafan @naglepuff said he could review on Monday. Can we add to this sprint? |
@naglepuff are you still planning to review this this week? |
@ssarrafan Yes, I'm working on this now. I should be able to get this back to @pkalita-lbl by EOD, sorry for the delay |
Fixes microbiomedata/submission-schema#168
These changes add a new "Metagenome (Long Read)" checkbox to the Multiomics Data screen in the submission portal. If selected, it enables a new corresponding tab in the DataHarmonizer screen. It all works analogously to the existing checkboxes and tabs.
It turned out that once that was implemented, switching between the Metagenome tab and the Metagenome (Long Read) tab surfaced a bug in the version of Handsontable used by [email protected] related to column headers not being updated correctly. This bug was fixed in the version of Handsontable used by the latest version of DataHarmonizer.
Upgrading from DataHarmonizer 1.4.7 to 1.6.5 actually corresponds to quite a large jump in Handsontable (7.4.2 to 13.1.0). Despite that, things seems to generally work fine. The one issue I found was that in certain situations columns were not sized correctly based on their header content. This was resolved by:
Update!
Further testing of this branch revealed two issues which have been fixed.
DataHarmonizer.validate()
became anasync
function and the call to it inHarmonizerApi.validate()
needed to be awaited. Debugging this also revealed an extraneous watcher onactiveInvalidCells
that was unnecessary.afterSelection
hook callback to throw an error due to passing in acol
value of-1
. I'm not 100% sure if this was a new bug caused by the DataHarmonizer upgrade or an existing one we just didn't notice before. Either way the fix was trivial.