Fix for bug where studies would not scroll to return to the top of the page when revisited #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eecavanna
approved these changes
Apr 24, 2024
|
@eecavanna Can you hit the merge button, I don't have permission to merge in this repo 😞 |
|
Looks good to me. I confirmed this fixes the issue in Chrome: nmdc-server-scroll-issue-fixed.mp4I will tag members of the Kitware team for final review, since I am still new to Vue.js and may miss some Vue.js faux pas (I wouldn't know them if I saw them). |
|
On second thought, I was already told that (from a collaboration standpoint) the Kitware team members are generally OK with me merging once I see that green "Merge" button (which I do). I'll go ahead and merge this in. If people notice scroll behavior that they don't like, they can create an issue about it. |
|
@eecavanna Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing this issue
We've added a scroll behavior line of code to return to the top of the study page when revisiting that page.