Fix metap ingest #1499
Merged
Fix metap ingest #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1496
Closes #1468
Special logic for gene function search wasn't being applied in all cases. Additionally, there were issues with ingesting MetaP gene function annotations that are resolved here, including a slight change to the data model on the mongo side. Further work should be done to remove the
best_proteincolumn from our database.Since the initial change is intended to be a hotfix, I am leaving out any data model changes to keep scope and complexity at a minimum. That progress will be tracked in #1484