Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unwanted project persistence #1009

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Conversation

microbit-matt-hillsdon
Copy link
Collaborator

@microbit-matt-hillsdon microbit-matt-hillsdon commented Sep 30, 2022

Session storage lasts for the lifetime of the tab, so we need to make sure subsequent migration URLs and iframe configurations work.

Motivated by issues with "Open in Classroom" and "Open in Python" on microbit.org.

Session storage lasts for the lifetime of the tab, so we need to make
sure subsequent migration URLs and iframe configurations work.
@jaustin
Copy link

jaustin commented Sep 30, 2022

I can switch between the two code snippets by navigating back/forward in this tab from the URLs you've provided (Ie this appears to fix the issue for me, here)

@microbit-matt-hillsdon microbit-matt-hillsdon changed the title Avoid unwanted project persistence. Avoid unwanted project persistence Sep 30, 2022
@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 5247665 into main Sep 30, 2022
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the persistence-bug branch September 30, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants