Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supports lookbehinds #17

Merged
merged 1 commit into from
May 14, 2019
Merged

supports lookbehinds #17

merged 1 commit into from
May 14, 2019

Conversation

doowb
Copy link
Member

@doowb doowb commented May 14, 2019

I noticed in another PR to micromatch that some tests were failing because node 12.2.0 would cause the utils.supportsLookbehinds method to return false.

  • only check minor when major is version 8
  • all majors greater than or equal to 9 support lookbehinds

@doowb
supports lookbehinds
1f63f7e 
- only check minor when major is version 8
- all majors greater than or equal to 9 support lookbehinds
@jonschlinkert
Copy link
Member

Thanks! LGTM!

@doowb doowb merged commit 22f8cbc into micromatch:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doowb @jonschlinkert