Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cimg/openjdk:16.0.1 for CircleCI #2520

Merged
merged 3 commits into from
Jul 16, 2021
Merged

Use cimg/openjdk:16.0.1 for CircleCI #2520

merged 3 commits into from
Jul 16, 2021

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Mar 22, 2021

This PR changes to use cimg/openjdk:16.0.0 for CircleCI.

@izeye
Copy link
Contributor Author

izeye commented Mar 22, 2021

Its build has failed as follows:

Execution failed for task ':micrometer-core:compileJava'.
> java.lang.IllegalAccessError: class org.gradle.internal.compiler.java.ClassNameCollector (in unnamed module @0xe7b777f) cannot access class com.sun.tools.javac.code.Symbol$TypeSymbol (in module jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.code to unnamed module @0xe7b777f

Gradle 6.8.3 doesn't seem to work on JDK 16.

@shakuzen
Copy link
Member

Gradle 6.8.3 doesn't seem to work on JDK 16.

Not without some workarounds, unfortunately. See gradle/gradle#13481. I think Gradle 7.0 should be out "soon", so perhaps we should just wait for that. It's a shame support without workarounds hasn't been released in a 6.x version of Gradle.

@shakuzen
Copy link
Member

Now that the Gradle 7 upgrade is in, this should be unblocked. Would you rebase and target it at the 1.5.x branch, please?

@shakuzen shakuzen added build A change in our build-system enhancement A general enhancement labels May 10, 2021
@shakuzen shakuzen added this to the 1.5.14 milestone May 10, 2021
shakuzen
shakuzen reviewed May 10, 2021
View reviewed changes
@shakuzen shakuzen modified the milestones: 1.5.14, 1.5.x May 12, 2021
@shakuzen
Copy link
Member

Backing this out of the 1.5.14 release since we're back to being blocked on upgrading to Gradle 7. While Gradle 6.9 can compile with JDK 16, it cannot run with it, which would require us to have two JDK versions in our build environment. We'll unfortunately have to come back to this when we can manage to upgrade to Gradle 7.

@jonatan-ivanov
Copy link
Member

@izeye Could you please try this with the latest 1.5.x?
See: #2693

(We also need to @Disable tests for the ExecutorService instrumentation if we want this now)

@shakuzen shakuzen changed the title Use cimg/openjdk:16.0.0 for CircleCI Use cimg/openjdk:16.0.1 for CircleCI Jul 16, 2021
@shakuzen shakuzen modified the milestones: 1.5.x, 1.5.17 Jul 16, 2021
shakuzen added 2 commits July 16, 2021 18:01
@shakuzen
Upgrade to openjdk 16.0.1 and skip failing test
ac1afff
@shakuzen
Upgrade Tomcat to 8.5.69
124717d 
Tests were failing with an InaccessibleObjectException on Java 16, which has been fixed in recent patch versions of Tomcat.
@shakuzen shakuzen changed the base branch from main to 1.5.x July 16, 2021 09:05
shakuzen
shakuzen reviewed Jul 16, 2021
View reviewed changes
micrometer-core/gradle.lockfile
@@ -104,8 +104,8 @@ org.apache.kafka:kafka-clients:2.5.0=compileClasspath,runtimeClasspath,testCompi
org.apache.kafka:kafka-streams:2.5.0=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
org.apache.logging.log4j:log4j-api:2.13.2=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
org.apache.logging.log4j:log4j-core:2.13.2=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
org.apache.tomcat.embed:tomcat-embed-core:8.5.54=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
org.apache.tomcat:tomcat-annotations-api:8.5.54=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
org.apache.tomcat.embed:tomcat-embed-core:8.5.69=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our Tomcat tests fail on Java 16 without this upgrade due to an InaccessibleObjectException.
https://tomcat.apache.org/tomcat-8.5-doc/changelog.html#Tomcat_8.5.62_(markt)

@shakuzen shakuzen merged commit e38a111 into micrometer-metrics:1.5.x Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakuzen shakuzen shakuzen left review comments

Assignees
No one assigned
Labels
build A change in our build-system enhancement A general enhancement
Projects
None yet
Milestone
1.5.17
Development

Successfully merging this pull request may close these issues.
3 participants
@izeye @shakuzen @jonatan-ivanov