Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.amazonaws:aws-java-sdk-cloudwatch from 1.12.608 to 1.12.609 #4489

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 11, 2023

Bumps com.amazonaws:aws-java-sdk-cloudwatch from 1.12.608 to 1.12.609.

Changelog

Sourced from com.amazonaws:aws-java-sdk-cloudwatch's changelog.

1.12.609 2023-12-08

Amazon CloudWatch

  • Features

    • Adds support for the OpenTelemetry 1.0 output format in CloudWatch Metric Streams.

Amazon Elastic Compute Cloud

  • Features

    • M2 Mac instances are built on Apple M2 Mac mini computers. I4i instances are powered by 3rd generation Intel Xeon Scalable processors. C7i compute optimized, M7i general purpose and R7i memory optimized instances are powered by custom 4th Generation Intel Xeon Scalable processors.

FinSpace User Environment Management service

  • Features

    • Releasing Scaling Group, Dataview, and Volume APIs
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [com.amazonaws:aws-java-sdk-cloudwatch](https://github.com/aws/aws-sdk-java) from 1.12.608 to 1.12.609.
- [Changelog](https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-java@1.12.608...1.12.609)

---
updated-dependencies:
- dependency-name: com.amazonaws:aws-java-sdk-cloudwatch
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependency-upgrade A dependency upgrade java Pull requests that update Java code labels Dec 11, 2023
@dependabot dependabot bot added this to the 1.11.x milestone Dec 11, 2023
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 1, 2024

Superseded by #4555.

@dependabot dependabot bot closed this Jan 1, 2024
@dependabot dependabot bot deleted the dependabot/gradle/1.11.x/com.amazonaws-aws-java-sdk-cloudwatch-1.12.609 branch January 1, 2024 21:46
@jonatan-ivanov jonatan-ivanov modified the milestones: 1.11.x, 1.11.9 Feb 1, 2024
@izeye
Copy link
Contributor

izeye commented Mar 1, 2024

There are four entries for com.amazonaws:aws-java-sdk-cloudwatch in the "Dependency Upgrades" section of the release notes. The final version for com.amazonaws:aws-java-sdk-cloudwatch in Micrometer 1.11.9 is 1.12.655 that has been done in #4730, so the other three entries including this don't need to be included in the release notes.

For reference, Spring Boot handles this case with "status: superseded" and "type: task" labels, for example, spring-projects/spring-boot#39579.

@shakuzen
Copy link
Member

shakuzen commented Mar 4, 2024

I agree we just want one entry, but unfortunately since dependabot titles dependency upgrades as from X to Y, if you don't have the earliest X, the final pull request title if used in the release notes will be misleading about what the version was changed from. I think Spring Boot avoids this by not using dependabot, using a custom tool (bomr) which isn't usable outside of Boot and doesn't say what version is being upgraded from, and by only running the tool once per release. We usually release on a monthly cadence and we've at some point changed the dependabot config (at least in this repo) to run monthly instead of daily or weekly. The intention is that that hopefully gets us closer to having one dependabot pull request per release per upgrade.

As for this specific case, I think it was just a mistake that a superseded pull request was added to the milestone. But if this pull request had been merged and then a subsequent one was opened to upgrade to an even newer version, we would have the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-upgrade A dependency upgrade java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants