Allow customizing start log message in PushMeterRegistry implementations #4848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will be helpful in troubleshooting to be able to log more specific information to the implementation than is available at the level of PushMeterRegistry. Allowing this to be overridden also avoids registry implementations from logging similar messages resulting in multiple logs on start for essentially the same thing.
shakuzen
added
enhancement
jonatan-ivanov
approved these changes
Mar 11, 2024
izeye
added a commit
to izeye/micrometer
that referenced
this pull request
May 23, 2024
jonatan-ivanov
pushed a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be helpful in troubleshooting to be able to log more specific information to the implementation than is available at the level of PushMeterRegistry. Allowing this to be overridden also avoids registry implementations from logging similar messages resulting in multiple logs on start for essentially the same thing.
See #4830 (comment)