Increase sleep time to avoid exemplar sampling rate limiting for openMetricsScrapeWithExemplars() #5908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases sleep time to avoid exemplar sampling rate limiting for the
openMetricsScrapeWithExemplars()
as it seems to be flaky, depending on scheduling.Looking into a failure, its output is as follows:
An exemplar sampling for the
summary_withHistogram_bucket{le="+Inf"} 3
entry seems to have been missed.I couldn't reproduce it locally, but if I reduce the sleep time to 1 ms, I could reproduce it.
This is an attempt to mitigate its flakiness by increasing chances for exemplar sampling to be scheduled in time.
See https://ge.micrometer.io/scans/tests?search.timeZoneId=Asia%2FSeoul&tests.container=io.micrometer.prometheusmetrics.PrometheusMeterRegistryTest&tests.sortField=FLAKY&tests.test=openMetricsScrapeWithExemplars()