Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: graal to 22.1.0 #7478

Merged
merged 2 commits into from
May 23, 2022
Merged

build: graal to 22.1.0 #7478

merged 2 commits into from
May 23, 2022

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented May 23, 2022

No description provided.

@sdelamo sdelamo requested a review from alvarosanchez May 23, 2022 07:22
alvarosanchez
alvarosanchez reviewed May 23, 2022
View reviewed changes
Copy link
Member

@alvarosanchez alvarosanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to upgrade version in gradle.properties

@alvarosanchez
Copy link
Member

This is failing due to oracle/graal#4518

@alvarosanchez alvarosanchez mentioned this pull request May 23, 2022
Merged
@sdelamo
Copy link
Contributor Author

sdelamo commented May 23, 2022

This is failing due to oracle/graal#4518

I have rolled back GraalVM svm to 22.0.0.2

@sdelamo sdelamo requested a review from alvarosanchez May 23, 2022 07:51
@alvarosanchez
Copy link
Member

@sdelamo GraalVM team suggests as you did: keeping the svm dependency at 22.0.x. Should be OK since it's a compileOnly dependency.

However, we still must generate a <graal.version>22.1.0</graal.version> property in the BOM. Will your latest commit make that happen?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sdelamo
Copy link
Contributor Author

sdelamo commented May 23, 2022 •
edited
Loading

I think it is correct.

rm -rf build/repo && ./gradlew pAPTBR  
% cat build/repo/io/micronaut/micronaut-bom/3.5.0-SNAPSHOT/micronaut-bom-3.5.0-20220523.083414-1.pom | grep graal
    <graalSdk.version>22.1.0.1</graalSdk.version>
    <graal.svm.version>22.0.0.2</graal.svm.version>
    <graal.version>22.1.0</graal.version>
        <groupId>org.graalvm.nativeimage</groupId>
        <version>${graal.svm.version}</version>
        <groupId>org.graalvm.sdk</groupId>
        <artifactId>graal-sdk</artifactId>
        <version>${graalSdk.version}</version>
        <artifactId>micronaut-graal</artifactId>

@sdelamo sdelamo requested a review from melix May 23, 2022 08:38
@sdelamo sdelamo added this to the 3.5.0 milestone May 23, 2022
@sdelamo sdelamo merged commit bb824ff into 3.5.x May 23, 2022
@sdelamo sdelamo deleted the graal221 branch May 23, 2022 09:17
@sdelamo sdelamo mentioned this pull request May 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarosanchez alvarosanchez alvarosanchez approved these changes

@melix melix melix approved these changes

Assignees
No one assigned
Labels
relates-to: graal type: dependency-upgrade Upgrade a dependency
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sdelamo @alvarosanchez @melix