Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly configure the parent BeanFactory #133

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Correctly configure the parent BeanFactory #133

merged 3 commits into from
Dec 2, 2020

Conversation

puneetbehl
Copy link
Contributor

  • Update MicronautApplicationContext setParent method to also set the parent BeanFactory.
  • Update MicronautBeanFactory doGetBean method implementation to first check the parent BeanFactory.

Fixes #132

@puneetbehl
#132 Correctly configure the parent BeanFactory
d454f5c 
* Update MicronautApplicationContext setParent method to also set the parentBeanFactory.
* Update MicronautBeanFactory doGetBean method implementation to first check in the parent BeanFactory.
@graemerocher
Copy link
Contributor

There are check style failures

@puneetbehl
Copy link
Contributor Author

Sorry for the trouble, I fixed checkstyle errors but not sure about the error related to Graal VM build.

@puneetbehl
Copy link
Contributor Author

The build would pass once the PR #131 is merged

@jameskleeh jameskleeh merged commit 8620a08 into master Dec 2, 2020
@jameskleeh jameskleeh deleted the parentBeanFactory branch December 2, 2020 20:25
puneetbehl added a commit that referenced this pull request Dec 19, 2020
@puneetbehl
Correctly configure the parent BeanFactory (#133)
49e156b 
* #132 Correctly configure the parent BeanFactory

* Update MicronautApplicationContext setParent method to also set the parentBeanFactory.
* Update MicronautBeanFactory doGetBean method implementation to first check in the parent BeanFactory.

* #132 Fixed checkstyle errors

(cherry picked from commit 8620a08)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graemerocher graemerocher Awaiting requested review from graemerocher

@jameskleeh jameskleeh Awaiting requested review from jameskleeh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Micronaut does not check the parent BeanFactory for the bean definition
3 participants
@puneetbehl @graemerocher @jameskleeh