Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ConfigProviderResolver.setInstance() #468

Closed
wants to merge 1 commit into from

Conversation

dmlloyd
Copy link
Contributor

@dmlloyd dmlloyd commented Oct 25, 2019

Fixes #364

Signed-off-by: David M. Lloyd [email protected]

@dmlloyd
Copy link
Contributor Author

dmlloyd commented Oct 25, 2019

@Emily-Jiang this should be considered for 1.4.

@eclipse-microprofile-bot
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Member

@Emily-Jiang Emily-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1. This is SPI and used by OSGi implementors. This class should not use this at all. Not sure why we should remove this and make implementors difficult to implement.

@dmlloyd
Copy link
Contributor Author

dmlloyd commented Oct 25, 2019

Continuing discussion on the issue (#364)

@dmlloyd
Copy link
Contributor Author

dmlloyd commented Mar 13, 2020

Closing for now. Will revisit the original use case later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigProviderResolver#setInstance is an implementation leak and should be dropped from the API
3 participants