Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow useProjectDependencies as a project-level setting #1393

Merged
merged 21 commits into from
Jan 20, 2025
Merged

Allow useProjectDependencies as a project-level setting #1393

merged 21 commits into from
Jan 20, 2025

Conversation

aholstrup1
Copy link
Collaborator

Allow useProjectDependencies as a project-level setting

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 14, 2025
View reviewed changes
Actions/AL-Go-Helper.ps1 Fixed Show fixed Hide fixed
Actions/AL-Go-Helper.ps1 Fixed Show fixed Hide fixed
Tests/DetermineProjectsToBuild.Test.ps1 Fixed Show fixed Hide fixed
Tests/DetermineProjectsToBuild.Test.ps1 Fixed Show fixed Hide fixed
Tests/DetermineProjectsToBuild.Test.ps1 Fixed Show fixed Hide fixed
Tests/DetermineProjectsToBuild.Test.ps1 Fixed Show fixed Hide fixed
freddydk
freddydk requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@freddydk freddydk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - left a few comments, no biggies
Let me know when I can take your branch for a spin in a few of my test repos.

Tests/DetermineProjectsToBuild.Test.ps1 Outdated Show resolved Hide resolved
Actions/DetermineProjectsToBuild/DetermineProjectsToBuild.psm1 Outdated Show resolved Hide resolved
Tests/DetermineProjectsToBuild.Test.ps1 Outdated Show resolved Hide resolved
@aholstrup1 aholstrup1 marked this pull request as ready for review January 16, 2025 10:32
@aholstrup1 aholstrup1 requested a review from a team as a code owner January 16, 2025 10:32
@aholstrup1 aholstrup1 changed the title [Draft] Allow useProjectDependencies as a project-level setting Allow useProjectDependencies as a project-level setting Jan 16, 2025
mazhelez
mazhelez previously approved these changes Jan 16, 2025
View reviewed changes
Tests/DetermineProjectsToBuild.Test.ps1 Outdated Show resolved Hide resolved
Actions/AL-Go-Helper.ps1 Outdated Show resolved Hide resolved
@freddydk
Copy link
Contributor

Looks good I think
Kicked off a full end 2 end to see whether there are side effects of this.

@aholstrup1 aholstrup1 merged commit 120540b into microsoft:main Jan 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazhelez mazhelez mazhelez approved these changes

@freddydk freddydk freddydk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aholstrup1 @freddydk @mazhelez