Unity: Placeholder functions for compilation #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 2, 2020
|
Thanks for this! I just realized I missed retargeting the Unity wrapper vcxproj to 2019. I'll do that and test this on Windows |
|
@rajat2004 I was able to build the Unity plugin successfully on Windows with this PR, but when I click on play with SimModeSelector, the engine crashes with no useful info. Do I need to absorb #2328 as well to test successfully? |
|
@saihv I don't think so, none of the changes in #2328 should actually impact Windows |
|
My bad, it was actually just a problem with my |
|
Great, glad to know it's working! |
madratman
force-pushed
the
unity-functions
branch
from
572836d to
5b48fd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compilation errors, tested to be working on Linux (Unity 2019.f2) after combining with #2328