Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detection support for all image types #3788

Merged
merged 3 commits into from
Jun 21, 2021

Conversation

alonfaraj
Copy link
Contributor

  • Extend detection support for all image types
  • UDetectionComponent now generated via c++ to keep it simpler and and without changing BP_PIPCamera asset

Fixes: #

#3472 (comment)

About

Last PR #3472 included image_type in API but supported only Scene.
This PR fix it.

How Has This Been Tested?

Using detection.py script on different image types with Block environment.

- Generate  detection component in c++ and revert BP_PIPcamera
@alonfaraj alonfaraj changed the title - Add detection support for all image types Add detection support for all image types Jun 13, 2021
@rajat2004
Copy link
Contributor

Slightly separate from this, there are 3 methods declared in AirBlueprintlib.h without any definition and usage, can be removed

static void addDetectionFilterMeshName(const std::string& name);
static void setDetectionFilterRadius(const float radius_cm);
static void clearDetectionMeshNames();

@zimmy87
Copy link
Contributor

zimmy87 commented Jun 21, 2021

Tested with detection.py script using a variety of different image types. Everything worked as intended so I am moving ahead with merging.

@zimmy87 zimmy87 merged commit 40b2978 into microsoft:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants