Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing netstandard1.x branching #1855

Merged
merged 2 commits into from
May 5, 2020
Merged

removing netstandard1.x branching #1855

merged 2 commits into from
May 5, 2020

Conversation

eddynaka
Copy link
Contributor

@eddynaka eddynaka commented May 5, 2020

Fix Issue #1767

Changes

  • removing branching #if netstandard1_x
  • removing inversed branching #if !netstandard1_x

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

@eddynaka eddynaka added the P2 label May 5, 2020
@eddynaka eddynaka added this to the 2.15 milestone May 5, 2020
@eddynaka eddynaka requested a review from TimothyMothra May 5, 2020 10:06
@eddynaka eddynaka self-assigned this May 5, 2020
@TimothyMothra TimothyMothra merged commit 76916ab into microsoft:develop May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants