Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] configuring source link #1904

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

eddynaka
Copy link
Contributor

@eddynaka eddynaka commented Jun 9, 2020

Fix Issue #1760 .

See comment history on original PR: #1800

Changes

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

@eddynaka
Copy link
Contributor Author

eddynaka commented Jun 9, 2020

@TimothyMothra , i created a branch inside the repository and it seems to work. Can you check using the package manager and the latest build?
image

@TimothyMothra
Copy link
Member

WOOT!! Nupkgs from the build server include SourceLink!!!

image

@TimothyMothra TimothyMothra marked this pull request as ready for review June 9, 2020 19:49
@TimothyMothra TimothyMothra merged commit d2e6e7b into develop Jun 9, 2020
@eddynaka eddynaka deleted the ednakamu/configuring-source-link branch June 16, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants