Skip to content
This repository has been archived by the owner on Aug 22, 2024. It is now read-only.

Error message cleanup #695

Merged
merged 6 commits into from
Sep 3, 2019
Merged

Conversation

wes-b
Copy link
Contributor

@wes-b wes-b commented Aug 28, 2019

Fixes #567
Fixes #496
Fixes #302

Description of the changes:

  • For access denied errors, where the device was already opened, I added additional logging to trigger the user to think about what might be cause the device to be unavailable.
  • The use of LIBUSB now disables logging when calling libusb_open and libusb_get_device_list as both those API's return errors that can't be disabled.
  • Rename 'queue_error' to 'queue_stop' as it is a better captures the state transition and allows de-escalation of error messages.

Errors and Warnings now seen when starting up K4aViewer:

[ warning  ] : depth_engine_thread(). Depth image processing is too slow at 76ms (this may be transient).
[ warning  ] : depth_engine_thread(). Dropping depth image due to bad timestamp at startup

Before submitting a Pull Request:

I tested changes on:

  • Windows
  • Linux

schultetwin1
schultetwin1 previously approved these changes Aug 29, 2019
Copy link
Contributor

@schultetwin1 schultetwin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awesome change. Thank you @wes-b!

rabbitdaxi
rabbitdaxi previously approved these changes Aug 30, 2019
Copy link
Member

@rabbitdaxi rabbitdaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wes-b wes-b dismissed stale reviews from rabbitdaxi and schultetwin1 via eb67b65 September 3, 2019 19:59
@wes-b wes-b merged commit 3c47d45 into microsoft:develop Sep 3, 2019
@wes-b wes-b deleted the error_message_cleanup branch September 3, 2019 23:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants