Skip to content

Commit

Permalink
Fix letsencrypt missing parameters (#4292)
Browse files Browse the repository at this point in the history
* Fix letsencrypt missing parameters

Fixes #3638

Update `core/terraform/outputs.sh` to handle empty `tre_output.json` file

* Add a check to see if `tre_output.json` is empty
* If `tre_output.json` is empty, run `terraform init` to recreate it

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/3638?shareId=XXXX-XXXX-XXXX-XXXX).

* Update version and changelog.
  • Loading branch information
marrobi authored Feb 5, 2025
1 parent 3838df2 commit 7ecd184
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ BUG FIXES:
* Fix VM actions where Workspace shared storage doesn't allow shared key access ([#4222](https://github.com/microsoft/AzureTRE/issues/4222))
* Fix public exposure in Guacamole service ([[#4199](https://github.com/microsoft/AzureTRE/issues/4199)])
* Fix Azure ML network tags to use name rather than ID ([[#4151](https://github.com/microsoft/AzureTRE/issues/4151)])
* Recreate tre_output.json if empty. ([[#4292](https://github.com/microsoft/AzureTRE/issues/4292)])

COMPONENTS:

Expand Down
2 changes: 1 addition & 1 deletion core/terraform/outputs.sh
100755 → 100644
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash
set -e

if [ ! -f ../tre_output.json ]; then
if [ ! -f ../tre_output.json ] || [ ! -s ../tre_output.json ]; then
# Connect to the remote backend of Terraform
export TF_LOG=""
# shellcheck disable=SC2154
Expand Down
2 changes: 1 addition & 1 deletion core/version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.11.20"
__version__ = "0.11.21"

0 comments on commit 7ecd184

Please sign in to comment.